Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR focuses on small refactors/optimizations: simplifying object instantiation syntax, cleaning up unused imports, and replacing a couple of manual loops with higher-level array helper functions.
Changes:
- Simplify
newexpressions by removing unnecessary parentheses in tests and the test driver. - Refactor test model to import
GenericModelinstead of using a fully qualified name. - Replace manual loop logic with
array_all()/array_find()and remove unuseduseimports.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/tests/TestDriverTest.php | Removes redundant parentheses around new in test fixtures. |
| test/tests/SQLTest.php | Simplifies new SelectField(...) expressions in SQL query tests. |
| test/src/TestModel.php | Switches to importing GenericModel for cleaner inheritance syntax. |
| src/Query/Generator/SQL.php | Removes an unused UnexpectedValueException import. |
| src/Driver/Test/TestTableEntryGroup.php | Refactors condition matching loop to array_all(). |
| src/Driver/Test/TestTable.php | Refactors entry lookup loop to array_find(). |
| src/Driver/Test/TestDriver.php | Removes redundant parentheses around new TestTableEntry(...). |
| src/Driver/Mysqli/MysqliException.php | Removes an unused mysqli import. |
| src/Driver/Mysqli/Mysqli.php | Minor import formatting cleanup. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.